Deleting the custom component default code deletes the node.

mui / toolpad

Toolpad: Full stack components and low-code builder for dashboards and internal apps.

https://mui.com/toolpad/

MIT License

964 stars 243 forks source link

Deleting the custom component default code deletes the node. #1421

Closed prakhargupta1 closed 1 year ago

prakhargupta1 commented 1 year ago

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹

https://user-images.githubusercontent.com/92228082/205879451-99ca0e57-cf55-4aa4-afe4-09d5d54641e1.mov

Current behavior 😯

No response

Expected behavior 🤔

No response

Context 🔦

No response

Your environment 🌎

master toolpad

apedroferreira commented 1 year ago

+1 Even trying to change the name seems to cause the same issue.

bytasv commented 1 year ago

I've tried with a brand new component, same thing does not happen. Seems that it happens with that specific instance only (or at least couldn't find a way to reproduce in other place yet). Need to figure out if it's related to the data binding or something that could cause it 🤔 or maybe we can reproduce by importing DOM locally so that the error is more descriptive (haven't tried it yet)

Janpot commented 1 year ago

I accidentally upgraded react-router-dom in https://github.com/mui/mui-toolpad/pull/1403/ even though I disabled it in renovatebot.

We're blocked on moving forward with this library on https://github.com/remix-run/react-router/issues/8139

Will fix.