search

mui / toolpad

Toolpad: Full stack components and low-code builder for dashboards and internal apps.
https://mui.com/toolpad/
MIT License
964 stars 243 forks source link

Disallow binding to properties that can be manipulated in the canvas #1614

Closed Janpot closed 1 year ago

Janpot commented 1 year ago

Duplicates

Latest version

Summary 💡

When using the drag handle to update the height for a datagrid. If the height property has been bound to, the binding will be removed without notice. Same for resizing/reordering and the columns prop Same for image height?

Since this is a potential footgun anyway, let's remove the ability for binding to these specific properties.

Examples 🌈

No response

Motivation 🔦

No response

apedroferreira commented 1 year ago

I think I didn't cover this here: https://github.com/mui/mui-toolpad/pull/1641 Will try to cover it too.

Edit: I think it covers this too after all.

apedroferreira commented 1 year ago

Reopened - it's still possible to bind to some of these properties in the binding editor, I'll exclude them.

apedroferreira commented 1 year ago

Finished fixing in https://github.com/mui/mui-toolpad/pull/1696