mui / toolpad

Toolpad: Full stack components and low-code builder for dashboards and internal apps.
https://mui.com/toolpad/
MIT License
964 stars 243 forks source link

Reference @types/node in user project #1662

Closed prakhargupta1 closed 1 year ago

prakhargupta1 commented 1 year ago

Duplicates

Latest version

Summary 💡

Currently in queries.js references to process.env... give type errors. We could think about a similar solution to the next-env.d.ts file?, but for toolpad

Examples 🌈

No response

Motivation 🔦

No response

apedroferreira commented 1 year ago

This seems to be working for me already, I'm getting types from node_modules/@types/node. Did anything change?

Janpot commented 1 year ago

Did anything change?

Looking into this, I think it gets installed transitively from dependencies of toolpad-app. I wrote this ticket when I was still messing around with a local setup that was based on yarn link and that didn't deal correctly with dependencies. For now we may be able to close this without further action.

apedroferreira commented 1 year ago

Looking into this, I think it gets installed transitively from dependencies of toolpad-app. I wrote this ticket when I was still messing around with a local setup that was based on yarn link and that didn't deal correctly with dependencies. For now we may be able to close this without further action.

Great, unless anything new comes up I will close it then.