Transforming query results in error

[cherniavskii]

Duplicates

• [X] I have searched the existing issues

Latest version

• [X] I have tested the latest version

Steps to reproduce 🕹

I've been following https://mui.com/toolpad/getting-started/quickstart/ and noticed that query transformation doesn't work

Steps:

1. Add a query and try to transform it as shown in the screenshot:

Current behavior 😯

Error in the query preview

Expected behavior 🤔

No errors in the query preview

Context 🔦

I looked into it quickly and the error seems to be coming from

https://github.com/mui/mui-toolpad/blob/217a17e7dc6f581210a175422cf86839a627fa21/packages/toolpad-app/src/toolpadDataSources/applyTransform.ts#L10

Given the transform function (data) => { return data.message }, the evaluated code looks like:

(data) => { return data.message }(/** data **/)

Shouldn't the transform function be wrapped in parenthesis?

-`${transformFn}(${JSON.stringify(data)})`,
+`(${transformFn})(${JSON.stringify(data)})`,

This seems to fix the issue. I can submit a PR

Your environment 🌎

No response

[Janpot]

This seems to fix the issue. I can submit a PR

Yep, good catch. This is a regression so we're going to add an integration test. We'll deal with, unless you feel particularly compelled to dig into the test suite 🙂

[cherniavskii]

We'll deal with

Sure, thanks!

[bharatkashyap]

We'll deal with

Sure, thanks!

Thanks for the catch, Andrew 👍