Observations when I used npx create-toolpad-app my-app command

[prakhargupta1]

1. I thought my-app is going to be the name of the folder. But the CLI asks me to Give a project name that becomes the name of the folder. So, where is my-app used?

It's the same name here (tools) but in another setup, I used different names.

2. I had another app running on port 3000. And this process couldn't pick a new port. Earlier it was working fine, so may be a regression?

3. App started with the yellow alert box saying 'Non-existent page undefined'.

I guess all of these will be fixed under: https://github.com/mui/mui-toolpad/pull/1795 but I thought of adding them here, just to be tracked.

[Janpot]

I believe it should work as follows:

• User provides a path yarn create toolpad-app path/to/my/app: toolpad doesn't prompt for a project name, app is created under the provided path. Note that it should be possible to specify . to use the current folder. If the path points to a non-empty folder, the CLI shows an error and exits
• User doesn't provide a path yarn create toolpad-app: toolpad prompts for a project name

[bharatkashyap]

1. I thought my-app is going to be the name of the folder. But the CLI asks me to Give a project name that becomes the name of the folder. So, where is my-app used?

This will indeed by solved by #1795

2. I had another app running on port 3000. And this process couldn't pick a new port. Earlier it was working fine, so may be a regression?

This is an unintended consequence of https://github.com/mui/mui-toolpad/pull/1882; the logic in the existing CLI was to abort if an explicitly specified port was found to be unavailable; the PR above adds a DEFAULT_PORT variable which results in the port being treated as having always been explicitly specified. I'll create a separate issue for that: #1903

App started with the yellow alert box saying 'Non-existent page undefined'.

This I can't replicate with the current version of the CLI, but regardless of that we do need to create an integration test for the CLI which I can work on: #1901

[bharatkashyap]

Okay to close this in favour of the individual linked issues @prakhargupta1?

[prakhargupta1]

Video for 3rd one: 2 issues: a. It automatically opens a wrong tab somehow b. Starts with the yellow box saying non-existent page

https://user-images.githubusercontent.com/92228082/232664578-79224932-7d03-4184-9646-9db26adef248.mov

This could be related to: https://github.com/mui/mui-toolpad/issues/1872

[Janpot]

b. is the probably same as the first point in https://github.com/mui/mui-toolpad/issues/1872#issuecomment-1506661235.

[prakhargupta1]

Marking it closed as there is just 1 open issue and it is being tackled separately