search

mui / toolpad

Toolpad: Full stack components and low-code builder for dashboards and internal apps.
https://mui.com/toolpad/
MIT License
963 stars 243 forks source link

[core] Should the authentication buttons be theme aware? #4015

Closed prakhargupta1 closed 3 weeks ago

prakhargupta1 commented 3 weeks ago

Summary

I was exploring Toolapd core theming and noticed that the buttons in sign-in and sign-out components are not theme aware. While a newly added button takes the primary.main of the palette (check the screenshot below). I would assume the authentication buttons to be theme aware.

Screenshot 2024-08-29 at 12 24 24 PM

Examples

No response

Motivation

No response

Search keywords: button

Janpot commented 3 weeks ago

The button is theme aware, it's just not a primary button. Do you think the sign-out button should be a primary action?

prakhargupta1 commented 3 weeks ago

Do you think the sign-out button should be a primary action?

In this account popover, it seems to be the primary and only action. But as menu item, No.