mui / toolpad

Toolpad: Full stack components and low-code builder for dashboards and internal apps.
https://mui.com/toolpad/
MIT License
1.27k stars 283 forks source link

PageContainer's title and breadcrumbs don't take the navigation segment into account #4100

Closed bourquep closed 1 month ago

bourquep commented 1 month ago

Steps to reproduce

Using the newly introduced segment property in AppProvider navigation. It does work in terms of selecting the proper navbar item when the current URL matches the segment, but the PageContainer doesn't seem to be able to properly extract/display the page title and breadcrumbs:

image image image

Current behavior

The AppProvider.title is displayed for both breadcrumbs and title by PageContainer.

Expected behavior

Breadcrumbs should be Studyo Go Admin / Users / 1234 and title should be settable via PageProvider.title.

Context

No response

Your environment

npx @mui/envinfo ``` System: OS: macOS 14.6.1 Binaries: Node: 20.9.0 - ~/.nvm/versions/node/v20.9.0/bin/node npm: 10.1.0 - ~/.nvm/versions/node/v20.9.0/bin/npm pnpm: Not Found Browsers: Chrome: 128.0.6613.138 Edge: Not Found Safari: 17.6 npmPackages: @emotion/react: 11.13.3 => 11.13.3 @emotion/styled: 11.13.0 => 11.13.0 @mui/base: 5.0.0-beta.58 @mui/core-downloads-tracker: 6.1.0 @mui/icons-material: 6.1.0 => 6.1.0 @mui/lab: 6.0.0-beta.9 @mui/material: 6.1.0 => 6.1.0 @mui/private-theming: 6.1.0 @mui/styled-engine: 6.1.0 @mui/system: 6.1.0 @mui/types: 7.2.16 @mui/utils: 6.1.0 @toolpad/core: 0.6.0 => 0.6.0 @toolpad/utils: 0.6.0 @types/react: ^18 => 18.3.5 react: ^18 => 18.3.1 react-dom: ^18 => 18.3.1 typescript: ^5 => 5.5.4 ```

Search keywords: segment

Janpot commented 1 month ago

@bourquep How would you feel about if we added a title and breadcrumbs property to the PageContainer to allow you to override for specific instances? It would still fall back to the current behavior.

bourquep commented 1 month ago

That would be great!

On Sep 16, 2024, at 04:04, Jan Potoms @.***> wrote:

@bourquep https://github.com/bourquep How would you feel about if we added a title and breadcrumbs property to the PageContainer to allow you to override for specific instances? It would still fall back to the current behavior.

— Reply to this email directly, view it on GitHub https://github.com/mui/mui-toolpad/issues/4100#issuecomment-2352252621, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAP4SFQ4WRIU55QPXNKOJLZW2GJTAVCNFSM6AAAAABOIBD4P2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJSGI2TENRSGE. You are receiving this because you were mentioned.

github-actions[bot] commented 1 month ago

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue. Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

[!NOTE] We value your feedback @bourquep! How was your experience with our support team? We'd love to hear your thoughts in this brief Support Satisfaction survey. Your insights help us improve!