muja / unrar.rs

Rust library for extracting, listing and testing RAR archives.
Apache License 2.0
95 stars 22 forks source link

remove `num` from dependency #30

Closed gwy15 closed 1 year ago

gwy15 commented 1 year ago

num 0.1 depends on rustc-serialize which "contain code that will be rejected by a future version of Rust". This commit removes num from dependency and use num_enum instead to derive from primitive methods for Code.

muja commented 1 year ago

Thanks for the heads up. I actually didn't know that this was the case. However I've already migrated from that dependency and instead use no dependency for the conversion in a bigger PR I've been preparing. See here

I'm also proud to say that no <1 dependencies are used anymore in that PR.

As such, I will be closing this. I'm not entirely sure when I'll be able to get the PR merged and a new version published. There is still lots of documentation missing which I have to write.