Empty display fields while creating typography field results in Fatal error: Uncaught TypeError

mujahidi / acf-typography

A Typography Add-on for the Advanced Custom Fields Plugin

https://wordpress.org/plugins/acf-typography-field/

GNU General Public License v2.0

18 stars 6 forks source link

Empty display fields while creating typography field results in Fatal error: Uncaught TypeError #21

Closed MuhammadFaizanHaidar closed 3 years ago

MuhammadFaizanHaidar commented 3 years ago

Error occurs in plugin/fields/acf-Typography-v5.php/line:383. There should be a check to see if $field['display_properties'] is not empty. Like this if( ! empty( $field['display_properties'] ) && sizeof($field['display_properties']) > 0){} If a user selects no field to display in the typography metabox then it should not break. I wanted to contribute but I was not able to play with branches.

mujahidi commented 3 years ago

Thanks @MuhammadFaizanHaidar This is already added to next patch I am working on.

mujahidi commented 3 years ago

Fixed in pull #22