mujo-code / puppeteer-headful

Github Action for puppeteer that is headful.
MIT License
100 stars 41 forks source link

Commands that are chained with && are not fully executed #114

Closed dvdvdmt closed 1 year ago

dvdvdmt commented 1 year ago

I've noticed that e2e tests in my project stopped working recently. Here is my config:

      - name: End-to-end tests
        uses: mujo-code/puppeteer-headful@master
        env:
          CI: 'true'
        with:
          args: npm run build:e2e && npm run test:e2e

You can see that it has npm run build:e2e && npm run test:e2e command. The problem is that when I run the action only the npm run build:e2e is being executed and the npm run test:e2e produces no logs. Could you please confirm if this is related to the puppeteer-headful action?

dvdvdmt commented 1 year ago

Eventually I simply rewrote this command and used a single instruction instead of two chained. I'm still don't know where is the issue, is it Github Actions args behavior or something else. I'll close the issue.