mujo-code / puppeteer-headful

Github Action for puppeteer that is headful.
MIT License
100 stars 43 forks source link

Bump node from 12.10.0 to 16.6.0 #78

Closed dependabot-preview[bot] closed 2 years ago

dependabot-preview[bot] commented 3 years ago

Bumps node from 12.10.0 to 16.6.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired)
stefanbuck commented 2 years ago

@jcblw any chance to get this merged? I'm in a weird situation where certain dependencies need at least node.js LTS (14.x at this time), but the test workflow fails due to the version specified here.

stefanbuck commented 2 years ago

Ohh look I'm a contributor 😄 I'm going to test this branch right now and report back if tests are still passing.

stefanbuck commented 2 years ago

Seems to work https://github.com/OctoLinker/OctoLinker/pull/1373/checks?check_run_id=3795379768#step:10:1

stefanbuck commented 2 years ago

@jcblw @alexanderdavide are you okay with me merging this PR? Before merging I'll cut of the current master as v1 and create a new branch v2. How does that sound?

jcblw commented 2 years ago

Yeah, I am good with it. Eventually would like to create a param where we can pass the version, but feel like this is a good update to have.

alexanderdavide commented 2 years ago

@jcblw @alexanderdavide are you okay with me merging this PR? Before merging I'll cut of the current master as v1 and create a new branch v2. How does that sound?

@stefanbuck I don't have any stake in this anymore so feel free!

stefanbuck commented 2 years ago

Eventually would like to create a param where we can pass the version

Mhhh I can't see how this will work with a Dockerfile or am I missing something?

jcblw commented 2 years ago

Eventually would like to create a param where we can pass the version

Mhhh I can't see how this will work with a Dockerfile or am I missing something?

Good question, TBH I have not looked into it much. Let me do a little research and see if I can find some open source projects that do something similar. I'll add the info to #1