muk-it / muk_dms

MuK Document Management System
GNU Lesser General Public License v3.0
91 stars 144 forks source link

you not gonna upgarde this module to odoo 13!!! please #133

Open Hashim-Khalid opened 4 years ago

Hashim-Khalid commented 4 years ago

upgrading muk dms to odoo 13 the problem in mixins_thumbnail.py in custom_thumnail_meduim to be spacific!! it's binary value that return is wrong!!

Hashim-Khalid commented 4 years ago

i tried myself but i couldn't

Hashim-Khalid commented 4 years ago

the problem in mixins_thumbnail.py in custom_thumnail_meduim to be spacific!! it's binary value that return nothing!!

pradhanashwin commented 4 years ago

@Hashim-Khalid did you figure out why the thumnails for files in kanban and form view doesn't appear? Or is it just for me that the issue is troubling me.

screenshot-localhost_8069-2020 02 19-13_46_04

screenshot-localhost_8069-2020 02 19-13_46_21

Hashim-Khalid commented 4 years ago

@Hashim-Khalid did you figure out why the thumnails for files in kanban and form view doesn't appear? Or is it just for me that the issue is troubling me. screenshot-localhost_8069-2020 02 19-13_46_04 screenshot-localhost_8069-2020 02 19-13_46_21

i have this issue also and figure out that it comes from mixins_thumbnail.py file because it can't find it's path or maybe something else. so if you find solution tell me please, i will be thankfull

pradhanashwin commented 4 years ago

i don't think mixins_thumbnail.py has the issue as the method _get_thumbnail_placeholder_image is returning same binary as that of svg. I think JS file is messing something

Hashim-Khalid commented 4 years ago

i don't think mixins_thumbnail.py has the issue as the method _get_thumbnail_placeholder_image is returning same binary as that of svg. I think JS file is messing something

i think also there is something wrong in js but what is wrong ??!! i don't have any experience in odoo js so i couldn't figure out it!!!

Hashim-Khalid commented 4 years ago

i have other problem with content field in form view, it's value doesn't appear after save. do you have it?

BanilSharma commented 4 years ago

I am waiting for odoo13 version for MUK DMS please :)

Hashim-Khalid commented 4 years ago

waiting.......................

mbilal4m commented 4 years ago

I'm waiting for v13

joyinfo commented 4 years ago

I ported it and got it working in https://github.com/joyinfo/muk_dms. You also need addons from https://github.com/joyinfo/muk_base and https://github.com/joyinfo/muk_web.

joyinfo commented 4 years ago

Can I submit pull request to this repository?

satriani-vai commented 4 years ago

Can I submit pull request to this repository?

Why do you ask? Just do it and the devs decide.

joyinfo commented 4 years ago

@satriani-vai thank you for answering. I am not familiar with the flow of github in this case.

Since this repository does not have a branch of 13.0 yet, can I submit a pull request to a branch not existing yet?