search

muk-it / muk_web

MuK Odoo Web Modules
GNU Lesser General Public License v3.0
109 stars 231 forks source link

12.0 IE incompatibility binary.js #121

Closed jeanpaulrobineau closed 5 years ago

jeanpaulrobineau commented 5 years ago

Hello,

I get a syntax error in IE browser on file /src/js/fields/binary.js On line 72

kind regards

jeanpaulrobineau commented 5 years ago

Dear, We found the problem, it's the , on line 71 which gives the issue, once removed it works fine kind regards

keshrath commented 5 years ago

https://github.com/muk-it/muk_web/blob/12.0/muk_web_utils/static/src/js/fields/binary.js#L71

This is not something I can just remove. Why doesn't it work on IE it's ES5 compatile or not?

jeanpaulrobineau commented 5 years ago

its the "," on line 74 in your code

this.formatOptions, should be this.formatOptions

without the , at the end

keshrath commented 5 years ago

https://github.com/muk-it/muk_web/commit/131de8da5bf55bb3d58988a634bc55ea6497a3cd