muk-it / muk_web

MuK Odoo Web Modules
GNU Lesser General Public License v3.0
108 stars 230 forks source link

Error while clicking arrow in the app search bar. #187

Open Canario0 opened 2 years ago

Canario0 commented 2 years ago

While trying to navigate with the arrows in the search bar of this theme, the following error triggers: muk_issue

I think is has somithing to do with the following assigment: https://github.com/muk-it/muk_web/blob/05ccc049451dc933b5410fb4afbeb4c46cd05322/muk_web_theme/static/src/js/core/search.js#L101

Were offset is a const variable but will happend the same with the following ones: https://github.com/muk-it/muk_web/blob/05ccc049451dc933b5410fb4afbeb4c46cd05322/muk_web_theme/static/src/js/core/search.js#L104 https://github.com/muk-it/muk_web/blob/05ccc049451dc933b5410fb4afbeb4c46cd05322/muk_web_theme/static/src/js/core/search.js#L94

Were all those variables are defined as const at: https://github.com/muk-it/muk_web/blob/05ccc049451dc933b5410fb4afbeb4c46cd05322/muk_web_theme/static/src/js/core/search.js#L89 https://github.com/muk-it/muk_web/blob/05ccc049451dc933b5410fb4afbeb4c46cd05322/muk_web_theme/static/src/js/core/search.js#L90 https://github.com/muk-it/muk_web/blob/05ccc049451dc933b5410fb4afbeb4c46cd05322/muk_web_theme/static/src/js/core/search.js#L91

daavii-b commented 1 year ago

While trying to navigate with the arrows in the search bar of this theme, the following error triggers: muk_issue

I think is has somithing to do with the following assigment:

https://github.com/muk-it/muk_web/blob/05ccc049451dc933b5410fb4afbeb4c46cd05322/muk_web_theme/static/src/js/core/search.js#L101

Were offset is a const variable but will happend the same with the following ones:

https://github.com/muk-it/muk_web/blob/05ccc049451dc933b5410fb4afbeb4c46cd05322/muk_web_theme/static/src/js/core/search.js#L104

https://github.com/muk-it/muk_web/blob/05ccc049451dc933b5410fb4afbeb4c46cd05322/muk_web_theme/static/src/js/core/search.js#L94

Were all those variables are defined as const at:

https://github.com/muk-it/muk_web/blob/05ccc049451dc933b5410fb4afbeb4c46cd05322/muk_web_theme/static/src/js/core/search.js#L89

https://github.com/muk-it/muk_web/blob/05ccc049451dc933b5410fb4afbeb4c46cd05322/muk_web_theme/static/src/js/core/search.js#L90

https://github.com/muk-it/muk_web/blob/05ccc049451dc933b5410fb4afbeb4c46cd05322/muk_web_theme/static/src/js/core/search.js#L91

You can change the variable definition from "const" to "let",