Closed huahyong closed 5 years ago
Merging #68 into 12.0 will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## 12.0 #68 +/- ##
=======================================
Coverage 58.26% 58.26%
=======================================
Files 20 20
Lines 369 369
=======================================
Hits 215 215
Misses 154 154
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 63de0ee...752fd5d. Read the comment docs.
Thanks for the PR. I can see your point that with light backgrounds you can't read the color very well. However, I have to say that I personally don't like the color that is created by the blend mode (mix-blend-mode: difference) very much. I will look at making this color adjustable.
As you wish. Thanks. By the way I don't think is a matter of chosen color. If the customer select a picture as background any color will have the problem.
That's a good point. https://github.com/muk-it/muk_web/commit/827ed023906fdcf9700d6efbad63c05eb555cda3
Thank you. just read the code. LGTM. Well done. I'll try it asap.
I tried it. Great job. It works fine on a new module installation. To make it work on a previously configured module I had to uninstall it and reinstall. A simple upgrade was not enough. Not a big problem though. Thank you very much.
Now you can choose any picture of any color as backgroud and you can be sure you are able to read the app names.