search

muk-it / muk_web

MuK Odoo Web Modules
GNU Lesser General Public License v3.0
109 stars 232 forks source link

Branding > Documentation & Support > Documentation link #86

Closed gregory-moka closed 5 years ago

gregory-moka commented 5 years ago

Hello, When I define a documentation link, by default, the plugin add /docmentation after the entered URL : https://TheDocumentationURL/subfolder/documentation

keshrath commented 5 years ago

Yes this is intended: https://github.com/muk-it/muk_base/blob/12.0/muk_branding/tools/debrand.py#L32 How would you expect it to work?

gregory-moka commented 5 years ago

Oops, sorry to be late. In fact, I thought I just need to paste the documentation url, and, that's all. According to the support apps you choose, you are not always able to change the default url of the documentation (ex : Website help Desk from SythilTech). So, I'm able to add some redirection rules to move users to the right page, but, it could be easier to use the pasted url. Thanks :)

keshrath commented 5 years ago

https://github.com/muk-it/muk_base/blob/12.0/muk_branding/tools/debrand.py#L35 https://github.com/muk-it/muk_base/blob/12.0/muk_branding/tools/debrand.py#L39

Try to change those two lines of code.

Unfortunately I can't test it at the moment, but I don't think I want to change it in general. The background is that most people will probably leave odoo as their documentation page and this will make sure it works with odoo. Since there are currently 2 variants of the links.

gregory-moka commented 5 years ago

Ok.. Paradoxal, cause, in my case, I use your app to hide Odoo, just to make think easier for final user. And, If I lead them to the odoo support.. But, ok, thanks for answering :)

keshrath commented 5 years ago

Yes of course this is the idea of this module, but especially with the documentation we have made the experience that it is better to refer to the Odoo page than to clone the whole documentation on an own server. And to make this possible it is unfortunately necessary to implement it this way. But I think you can change it by making a small change in the code or by setting a webserver to do so.