mukaschultze / nativescript-windowed-modal

Consistent modals for Android and iOS
https://www.npmjs.com/package/nativescript-windowed-modal
Apache License 2.0
47 stars 18 forks source link

iOS: ModalStack swallowing ListView tap events #3

Open jnorkus opened 5 years ago

jnorkus commented 5 years ago

Which platform(s) does your issue occur on?

Please, provide the following version numbers that your issue occurs with:

Please, tell us how to recreate the issue in as much detail as possible.

Place a ListView inside a ModalStack and handle its itemTap event. outsideTap gets called, correctly identifies that it was inside the rect, returns. But event doesn't reach the handler.

edusperoni commented 5 years ago

Reference project:

https://play.nativescript.org/?template=play-ng&id=Lrwg8A

comment ModalStack out and listview will work. Tapping the label which has its own tap works

edusperoni commented 5 years ago

This is a bug with nativescript. binding a tap on a parent element prevents tapping on the listview:

https://play.nativescript.org/?template=play-ng&id=Lrwg8A&v=4

We'll open an issue shortly

mukaschultze commented 5 years ago

Issue: NativeScript/NativeScript#6718

edusperoni commented 5 years ago

Actual issue for reference: https://github.com/NativeScript/NativeScript/issues/6376

darrenkhouston commented 5 years ago

For fullscreen Modals, I used a <StackLayout> instead of the defined <ModalLayout>, and my @itemTap worked like normal, just in case anyone is needing a quick fix. I guess it's the same as commenting it out, but if you are using the parent <ModalLayout> for styling, like .modal-container, this might be a solution for you.

mukaschultze commented 5 years ago

The ModalStack is used for layout and closing the modal when touching outside of the child frame, this feature won't work without it, and can cause some inconsistency between Android and iOS.

romandrahan commented 5 years ago

@mukaschultze, same for me. Do you know how we can do any workaround?