Tweaks to improve cleanliness of code; removes warnings that appear in Eclipse

mukel / llama3.java

Practical Llama 3 inference in Java

MIT License

514 stars 61 forks source link

Tweaks to improve cleanliness of code; removes warnings that appear in Eclipse #11

Open SkyAphid opened 2 months ago

SkyAphid commented 2 months ago

-Surrounded Scanner in runInteractive() in try blocks -Tweaked precomputeFreqsCis() and removed code that doesn't appear to do anything (triggers a warning in Eclipse) -Added @SuppressWarnings("preview") to loadModelImpl()

SkyAphid commented 2 months ago

Alright, sorry. This was the first time I'd ever done a pull request since I usually just build my own tools. I'll fix it up when I have time.

SkyAphid commented 2 months ago

Alright, I've adjusted it based on your feedback. That said, this version does include a git ignore file, but that's specifically so it won't push the classpath, project file, and other unwanted items. I think you can delete that on your end though.

Sorry for all of the mistakes! I hope this is useful to you.