Breaking Api Changes on Patch Update Causes Compile Issues - Githubissues

mukeshsolanki / android-otpview-pinview

A custom view to enter otp of different sizes used usually in cases of authentication.

MIT License

707 stars 207 forks source link

Breaking Api Changes on Patch Update Causes Compile Issues #112

Closed sdoward closed 3 years ago

sdoward commented 3 years ago

Subject of the issue

Api change: XML naming has been changed. Otp prefix has been added.

Steps to reproduce

Use the lib in 2.1.0 with app:itemCount="4" and update to 2.1.2

Expected behaviour

No breaking changes are found

Actual behaviour

The projects cannot compile because the API has changed.

There are no actions to take now as the artefact has already been published however I thought I would create the issue for future reference.

Any breaking changes should use a MAJOR version bump. In this case 3.0.0. See semver

This issue can likely be closed. Thanks for the work on this project!