Adapt to be compatible with Leaflet 1.3.1

mukil / Leaflet.annotate

A Leaflet plugin integrating schema.org to markup items in your geographic web map machine readable.

http://mukil.github.io/Leaflet.annotate/

BSD 2-Clause "Simplified" License

10 stars 5 forks source link

Adapt to be compatible with Leaflet 1.3.1 #10

Open mukil opened 7 years ago

mukil commented 7 years ago

I can confirm that this plugin does not run out-of-the-box when using Leaflet 1.0. So, as assumed, using Leaflet 0.7.7 is required.

mukil commented 6 years ago

http://leafletjs.com/examples/extending/extending-1-classes.html for 1.3.1

mukil commented 6 years ago

The way to go now seems to be one of the following ways:

L.Class.include() and addInitHook to run extra constructor code.
Implementing a Handler

The current implementation uses the approach of "Changing parts of an existing class (replacing how a class method works)" and this seems to be to tightly coupled to unforeseeable changes in upcoming versions of LeafletJS.

mukil commented 6 years ago

But to keep the backwards-compatibility for automatically annotating web maps already created with Leaflet, the Leaflet-Schema.org-Dubine Core integration should continue to be tightly coupled with at least the following items of the Leaflet Standard API: Marker, CircleMarker, Popup, ImageOverlay and GeoJSON (as does Leaflet.annotate 0.3 do through building annotations on custom properties in the respective options object, see API Doc).