codecov-commenter
commented
2 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
fca545d) to head (90fce47). Report is 1 commits behind head on master.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #428 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 42 42 Lines 3674 3672 -2 ========================================= - Hits 3674 3672 -2 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Now we only keep value when fieldNum is 253 and the value type is uint32. We no longer return ErrFieldValueTypeMismatch error when the fieldNum 253 is not an uint32, as there is no documentation that say 253 must be for timestamp and we found some old message may have timestamp for other fieldNum such as CoursePoint and Set messages, although these messages may be created before the rule was put in place. We think that maybe some manufacturers use this fieldNum for something else as well. We don't think returning error will add any value.
Some errors are deleted or make private; ErrDataSizeZero is deleted and an ErrNotFITFile will be returned instead when FileHeader's DataSize is zero.