Excel file export, datetime changes

mukunku / ParquetViewer

Simple Windows desktop application for viewing & querying Apache Parquet files

GNU General Public License v3.0

754 stars 91 forks source link

Excel file export, datetime changes #54

Closed sujeendran closed 2 years ago

sujeendran commented 2 years ago

Hi, Thank you for building this tool! It is very helpful in my work. I have added few features that are useful for me and thought others also might find some use with it. Please feel free to review the changes and if you find them useful we can merge it.

Changes included:

Added support for Excel (*.xlsx) file export
Added an option to toggle short date format while exporting CSV.
Removed outdated dependency checks in ParquetViewer.csproj file.
Updated nuget packages.

Disclaimer: I don't think I have extensively tested support for all the data types for excel file export.

mukunku commented 2 years ago

Thanks so much for the contribution. I created #58 now to get this released. I did end up making some changes:

I ditched xlsx and changed it to xls because the executable size was increasing from 1.5MB to 8MB with the ClosedXML package being included. I added a raw Excel writer so ended up not having to add any new packages
I added a bunch of date formats and made it so the date format in the export matches the date format on screen. While not ideal I think that's going to be the least confusing.

Really appreciate the effort you put into this; I wouldn't have been able to add these features if you hadn't.

sujeendran commented 2 years ago

Glad to see the changes being including in the new release :) Also your changes make sense.