[BUG] Close button is not at the top right

mukunku / ParquetViewer

Simple Windows desktop application for viewing & querying Apache Parquet files

GNU General Public License v3.0

689 stars 82 forks source link

[BUG] Close button is not at the top right #56

Closed Caceresenzo closed 1 year ago

Caceresenzo commented 1 year ago

Parquet Viewer Version v2.3.6

Describe the bug The window's close button is not exactly at the top right of the page. Clicking exactly at the right close windows behind.

Screenshots Untitled

Additional context You must be exactly at the very very top right. It must be only a 1px gap.

mukunku commented 1 year ago

It's not that way for me on Windows 10:

Which OS are you on? Also, could you test it with the latest beta release? Maybe it's fixed now for you: https://github.com/mukunku/ParquetViewer/releases/tag/v2.3.7

keen85 commented 1 year ago

I can confirm that also on Windows 10 with the v2.3.7 pre-release there is 2px gap if the window is maximized.

However:

even when hovering over the 2px gap, the button is targeted nonetheless. If I place my cursor in the top right corner of my screen and click, the application is closed. So, I can't replicate the original issue of @Caceresenzo.
also other applications (e.g. notepad, taskmanager, mspaint) show the same behavior: if the windows is maximized, there is a visual gap

mukunku commented 1 year ago

Thanks for the info @keen85 .I saw similar behavior when testing locally: there is a gap when full screen but I can still close the window at the top right of the screen. Lets see what OP says. Maybe @Caceresenzo has a second monitor that is off screen which is causing the issue for them?

Honestly we're just using the default WinForms UI here so not sure if there's anything that can be done to change how the "X" is rendered on the window.

Caceresenzo commented 1 year ago

Sorry for the late answer.

Yes you are right. I am on Windows 10, using a second 2560x1440 monitor with 125% scale, and the problem is when the application is maximized.

The v2.3.7 pre-release hasn't fixed the problem for me.

mukunku commented 1 year ago

Hey @Caceresenzo , the latest beta release has been built with .NET 7 which has changed some fundamental stuff around WinForms rendering. Can you give this version a try and see if the issue is maybe fixed for you now?

https://github.com/mukunku/ParquetViewer/releases/tag/v2.5.1

Caceresenzo commented 1 year ago

The gap still seems to be here:

But now the mouse will always "click on it". So its not an issue anymore?

Thanks a lot for your update @mukunku

mukunku commented 1 year ago

Yay 🙌🏼 At least it works for you now. Closing out this ticket.