search

mukunku / ParquetViewer

Simple Windows desktop application for viewing & querying Apache Parquet files
GNU General Public License v3.0
687 stars 82 forks source link

Adding autosaving of Max Row count #66

Closed dannysummerlin closed 1 year ago

dannysummerlin commented 1 year ago

I have added an AppSetting to save the default row count based on whatever you last set it to. I have never built anything in C#, so I'm not 100% I got the int handling right, but I hope I got pretty close. Obviously the best version of this would allow people to toggle this behavior, but that is way over my head!

mukunku commented 1 year ago

Thanks for the contribution! I agree that this should be toggleable. I'll see when I can get some time to add that in before merging your PR.

dannysummerlinjstartorg commented 1 year ago

Awesome, thanks, and if I get some brain room to learn more I'll try to contribute on that!

mukunku commented 1 year ago

I added the feature to the v2.5.1 release now: https://github.com/mukunku/ParquetViewer/releases/tag/v2.5.1 🙌🏼

I also added an option under the Edit menu to enable/disable the feature.