[BUG] sbyte and byte types swapped

[maurikke]

Parquet Viewer Version Version 2.7.0.0.

Where was the parquet file created? My own tool

Describe the bug In the parquet viewer SByte and Bye are mixed up:

your code:

    private static Type ParquetNetTypeToCSharpType(Parquet.Thrift.SchemaElement thriftSchema, Parquet.Schema.DataType type)
        {
            Type columnType;
            switch (type)
            {
---removed some lines---
                case Parquet.Schema.DataType.Byte:
                    columnType = typeof(sbyte);    --> should be typeof(byte) as a .Net byte is unsigned
                    break;
---removed some lines---
                case Parquet.Schema.DataType.SignedByte:
                    columnType = typeof(byte);   --> should be typeof(sbyte) as a .Net byte is unsigned
                    break;
---removed some lines---            }

            return columnType;
        }

atleast fixed solved the problem for my test.

Kind regards, Maurice,

[mukunku]

Thanks for the report. This has been fixed now in: https://github.com/mukunku/ParquetViewer/releases/tag/v2.7.0.3