Closed GoogleCodeExporter closed 9 years ago
The patch works. I don't know about it's placement - guess it could stay there
if we want that button. May I ask why are you disabling it after the stop
button is pressed? That seemed like the exact moment someone would like to use
it.
Original comment by netpr...@gmail.com
on 23 Oct 2010 at 10:26
As for the placement, I originally thought about putting it on the right under
the outputText, but my Swing expertise is lacking. I you want the button at
all, you are welcome to move it wherever you like. And yes, it shouldn't be
disabled after the stop button is pressed. I originally added the toggling to
avoid having people copy the greeting text. After the initial start button
press, it should never be toggled back to disabled state.
Original comment by Raiko...@gmail.com
on 23 Oct 2010 at 1:05
Just need to figure out where to put it.
Original comment by Frit...@gmail.com
on 23 Oct 2010 at 5:31
Maybe merge Start and Stop into one button and replace the Start button with
copy build to clipboard with an icon instead of a label?
Original comment by netpr...@gmail.com
on 23 Oct 2010 at 7:08
I can work on a patch for the start/stop toggle thought. Not sure how the
clipboard icon button would work out, though. It seems like too much
information to convey with a single icon. While the typical copy/paste icon
might conjure up some ideas, it may be unclear what exactly you would be
copying. Would it be the target build you entered? Would it be the build
itself? If the button were moved to the right side of the interface, it might
be more clear. However, we have a lot more horizontal space in the right frame
than in the left, so an icon might not be entirely necessary.
I'll work on a patch and submit it via comment tomorrow.
Original comment by Raiko...@gmail.com
on 24 Oct 2010 at 7:41
done
Original comment by azzur...@gmail.com
on 25 Oct 2010 at 4:06
Original issue reported on code.google.com by
Raiko...@gmail.com
on 22 Oct 2010 at 8:07Attachments: