mulander / evolutionchamber

Automatically exported from code.google.com/p/evolutionchamber
0 stars 0 forks source link

Add "copy build to clipboard" button #48

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
It would be useful to be able to copy the currently displayed build from the 
outputText JTextArea directly to the clipboard. I tested an implementation of 
this in my local checkout and it seems to be working. I've attached a patch 
file to be applied to EcSwingX.java (revision 40) if you are interested in 
adding the feature. I must admit, I am not a Swing expert so there may indeed 
be a more elegant approach to adding the button (and a better button location, 
for that matter). I hope this helps... Thanks for your work on this project!  

Original issue reported on code.google.com by Raiko...@gmail.com on 22 Oct 2010 at 8:07

Attachments:

GoogleCodeExporter commented 9 years ago
The patch works. I don't know about it's placement - guess it could stay there 
if we want that button. May I ask why are you disabling it after the stop 
button is pressed? That seemed like the exact moment someone would like to use 
it.

Original comment by netpr...@gmail.com on 23 Oct 2010 at 10:26

GoogleCodeExporter commented 9 years ago
As for the placement, I originally thought about putting it on the right under 
the outputText, but my Swing expertise is lacking. I you want the button at 
all, you are welcome to move it wherever you like. And yes, it shouldn't be 
disabled after the stop button is pressed. I originally added the toggling to 
avoid having people copy the greeting text. After the initial start button 
press, it should never be toggled back to disabled state.

Original comment by Raiko...@gmail.com on 23 Oct 2010 at 1:05

GoogleCodeExporter commented 9 years ago
Just need to figure out where to put it.

Original comment by Frit...@gmail.com on 23 Oct 2010 at 5:31

GoogleCodeExporter commented 9 years ago
Maybe merge Start and Stop into one button and replace the Start button with 
copy build to clipboard with an icon instead of a label? 

Original comment by netpr...@gmail.com on 23 Oct 2010 at 7:08

GoogleCodeExporter commented 9 years ago
I can work on a patch for the start/stop toggle thought. Not sure how the 
clipboard icon button would work out, though. It seems like too much 
information to convey with a single icon. While the typical copy/paste icon 
might conjure up some ideas, it may be unclear what exactly you would be 
copying. Would it be the target build you entered? Would it be the build 
itself? If the button were moved to the right side of the interface, it might 
be more clear. However, we have a lot more horizontal space in the right frame 
than in the left, so an icon might not be entirely necessary.

I'll work on a patch and submit it via comment tomorrow.

Original comment by Raiko...@gmail.com on 24 Oct 2010 at 7:41

GoogleCodeExporter commented 9 years ago
done

Original comment by azzur...@gmail.com on 25 Oct 2010 at 4:06