Closed GoogleCodeExporter closed 9 years ago
Original comment by azzur...@gmail.com
on 26 Oct 2010 at 8:27
If you're going to refactor actions, it will improve speed to take out all the
anonymous classes and make them static nested classes.
Original comment by brendan....@gmail.com
on 26 Oct 2010 at 8:46
It is unclear if static nested classes provide any benefit. See here
http://stackoverflow.com/questions/758570/is-it-possible-to-make-anonymous-inner
-classes-in-java-static
Original comment by sergey...@gmail.com
on 26 Oct 2010 at 10:44
sergeykad,
Could you provide a patch that demonstrates this?
Original comment by mike.angstadt
on 17 Nov 2010 at 3:46
I'll try to create a patch till Sunday to demonstrate the change I have in
mind. It will include 2-3 classes as proof of concept only (and therefore will
break compilation of the rest of EcAction subclasses).
Original comment by sergey...@gmail.com
on 17 Nov 2010 at 4:42
That's ok. I think that it would help a lot to see a solid example. Thanks a
lot.
Original comment by mike.angstadt
on 17 Nov 2010 at 10:58
I checked the code and I see Fritley already implemented changes very similar
to one I have in mind. I guess the issue can be closed.
Original comment by sergey...@gmail.com
on 19 Nov 2010 at 8:34
Setting as fixed by Fritley upon sergeykad's request.
Original comment by netpr...@gmail.com
on 19 Nov 2010 at 9:39
Original issue reported on code.google.com by
sergey...@gmail.com
on 26 Oct 2010 at 7:28