search

mulbc / gosbench

Distributed S3 benchmarking tool - Replacement of Cosbench
GNU General Public License v3.0
44 stars 16 forks source link

Updated AWS S3 packages to Version 2 #29

Closed bugfix4u closed 2 months ago

bugfix4u commented 2 months ago

Updated AWS S3 APIs to V2 since AWS has announced that the Golang V1 API will be going EOL. Added a version to the docker build image to match the go.mod go version. Pulling the latest image failed to build the worker.

mulbc commented 2 months ago

So for me the "make build" was broken, since I had an old version of golang:alpine on disk and "docker build" didn't check for updates. To remedy this, I added a docker pull to the Makefile and reverted your change for now (which was pulling golang 1.20, while we need 1.21+ for toolchains)

Rest of the PR looks wonderful, thank you so much for your work