search

mulbc / vaultPass

A Chrome extension to leverage Hashicorp Vault as Credential Storage for teams
MIT License
96 stars 38 forks source link

Count of secrets #23

Closed afteroot closed 3 years ago

afteroot commented 3 years ago

Could you please add count of secrets via setBadgeText

So if in Vault any of secrets exists so we can disaply it on icon with setBadgeText ex:

chrome.tabs.onActivated.addListener(function() {
  chrome.storage.sync.set({number: 1}, function() {
    chrome.browserAction.setBadgeText({text: "3"+Math.random()});
  });
});
mulbc commented 3 years ago

That's a good idea! Let me see if I can add that soon

afteroot commented 3 years ago

Sound's good) waiting )

afteroot commented 3 years ago

and also please make check of this https://github.com/sa2rn/vaultPass made some modify

mulbc commented 3 years ago

I've created https://github.com/mulbc/vaultPass/pull/24 to get those changes downstream, thanks for letting me know

afteroot commented 3 years ago

Yep, sure .. wait a while .. im on vacation )

mulbc commented 3 years ago

c4fea64 implements the badgeText now and I also merged the PR

Will (try to) get this new version into the Google and Firefox store soon

afteroot commented 3 years ago

Looks good!