mulbc / vaultPass

A Chrome extension to leverage Hashicorp Vault as Credential Storage for teams
MIT License
97 stars 38 forks source link

Update search functionality #39

Closed SamuZad closed 1 year ago

SamuZad commented 1 year ago

Update the search functionality with the following:

  1. Modified the event listener so that it only starts running when Enter is pressed. This prevents the aggressive reload every time the searchString changes.
  2. Moved the "No matching key" messages out of the for loop, so they don't get sent every time a secret is iterated on. Instead, a message will be sent at the end of the search.
  3. Split the "No matching key" messages, so they better indicate whether it was a search or "default page load behaviour" that yielded no results.
  4. Modified search behaviour so that it can search for substrings. Ie if the secret is "bbc.com", and we search for "bbc.co", it will be found as a match during manual search.
  5. After the search string is set to empty and Enter is pressed, the default behaviour will take place
mulbc commented 1 year ago

@SamuZad & @Gerard-CK With the sudden influx of good PRs i do have to wonder... Are you working for the same company?

SamuZad commented 1 year ago

@SamuZad & @Gerard-CK With the sudden influx of good PRs i do have to wonder... Are you working for the same company?

To my knowledge.. we have nothing to do with each other 😅

Gerard-CK commented 1 year ago

@SamuZad & @Gerard-CK With the sudden influx of good PRs i do have to wonder... Are you working for the same company?

To my knowledge.. we have nothing to do with each other 😅

I concur. I think it's a case of great minds think alike. :-)

SamuZad commented 1 year ago

@mulbc the debouncer will be handled as a separate PR. Could we get a merge, if you are happy with this?

mulbc commented 1 year ago

There are a few more changes in here than I can immediately overlook. Thus I would like to do some more verification before I merge this, which will take me a few days. Thanks for your patience and great work in assembling all the PRs