search

mulbc / vaultPass

A Chrome extension to leverage Hashicorp Vault as Credential Storage for teams
MIT License
96 stars 38 forks source link

[INFRA-1778][All] Create & implement a nice app icon #4

Closed ThibaultJanBeyer closed 5 years ago

ThibaultJanBeyer commented 5 years ago

As a user I want to be able to differentiate the extension easily from other extensions.

Currently, the extensions icon is just the default material design key It would make sense to have an icon that somehow represents Vault as well since this is a Vault companion app

Before:

App icon:

screenshot 2019-01-31 at 13 04 18

Extension icon inline:

screenshot 2019-01-31 at 13 04 33

After:

App icon:

screenshot 2019-01-31 at 13 03 54

Extension icon inline:

screenshot 2019-01-31 at 13 03 28

Note: after merging this PR we will have to adapt the stylesheet, since https://github.com/mulbc/vaultPass/pull/1 uses background: url('/icon.svg'); on the list title which should be background: url('/icons/key.svg'); after this PR

mulbc commented 5 years ago

Note: after merging this PR we will have to adapt the stylesheet, since #1 uses background: url('/icon.svg'); on the list title which should be background: url('/icons/key.svg'); after this PR

Why don't you just add this to this PR?

1 is merged now :)

ThibaultJanBeyer commented 5 years ago

Why don't you just add this to this PR?

1 is merged now :)

Ah perfect 👌

ThibaultJanBeyer commented 5 years ago

Done, can be merged now :)