Allow custom secrets path and multiple passwords for the same website

Gerard-CK commented 1 year ago

This is a relatively big PR with major enhancements. I suggest reviewing one commit at a time starting from the oldest one first.

Enhancement 1: Allow more than one password per website. VaultPass can now extract multiple username/password pairs from any given secret [possibly address issue #33]

Enhancement 2: User can specify which KV store they wish to use (the default still being /secret/vaultPass) [possibly address issue #20]

Bug fixes:

Only display No matching key found for this page only once instead of once per selected directory

Clearing the Search Secrets box will re-display credentials that match the current URL (if there were any)
Only autofill generic text field with matching username if it is part of the same form as the identified password field or when the user manually requested credentials to be filled

Gerard-CK commented 1 year ago

Just a nudge on this. Are these new features of any interest?

mulbc commented 1 year ago

very much of interest, I was sick for a few days and got swamped with work. I do have some time now and will try to finish the review for both PRs today

mulbc commented 1 year ago

@Gerard-CK - I rebased your code on the other PR that I merged before. It all looks fine to me and I'm ready to merge, just wanted to give you a chance to have a quick look over it yourself if you have the time

Gerard-CK commented 1 year ago

Hi, sorry to hear that you were sick but good to hear you're back and in good shape. Had a look at the rebase, looks good to me.

Cheers

mulbc / vaultPass

Allow custom secrets path and multiple passwords for the same website #40