search

mulbc / vaultPass

A Chrome extension to leverage Hashicorp Vault as Credential Storage for teams
MIT License
96 stars 38 forks source link

Title is not showing #43

Closed jmayoranoexactas closed 1 year ago

jmayoranoexactas commented 1 year ago

Describe the bug Since commit 4f36891ac147f86ed6aa6a37ff9ea5e8654e598b, vaultPass extension is not showing title in the secrets list. I have configured a lot of secrets with title and comment like example credentials in K2 tutorial(https://github.com/mulbc/vaultPass/blob/master/docs/access_policies_v2.md)

I think the problem is extractCredentialsSets method in popup.js That method only returns username and password

jmayoranoexactas commented 1 year ago

With code in popup.js line 148 I was able to resolve the problem: title: data.hasOwnProperty('title') ? data['title'] : '',

mulbc commented 1 year ago

So... This can be closed again?

jmayoranoexactas commented 1 year ago

sorry, I need to know if it will be resolved in the next release

phoenix-henri commented 1 year ago

That would be interesting to know for me as well, since a missing title would trigger a huge change in the structure

phoenix-henri commented 1 year ago

I tested out the code in master branch and it seems like all the username-password pairs show only the title saved in "title" and not the corresponding "title.extension". @jmayoranoexactas is this intended in your changes or is it just a minor bug?

Gerard-CK commented 1 year ago

I tested out the code in master branch and it seems like all the username-password pairs show only the title saved in "title" and not the corresponding "title.extension". @jmayoranoexactas is this intended in your changes or is it just a minor bug?

PR #45 should address this.

I've also noticed the comment is read but never used. Where should that comment be displayed?