Added anchor tags to the html. Fixes #28 - Githubissues

mulberrysymbols / mulberry-symbols

Communication symbol set designed for adults with language difficulties

https://mulberrysymbols.org

Other

38 stars 11 forks source link

Added anchor tags to the html. Fixes #28 #33

Closed gavinhenderson closed 5 years ago

gavinhenderson commented 5 years ago

Added anchor tags to the html so you can now link to things by doing #category-here

Addressing #28

SteveALee commented 5 years ago

Actually can I add a bit of feature creep? :) Can we have a perma link just after the category text. Like these in WCAG but not right justified?

There is also a tooltip in those which might help people understand.

<span class="permalink">
  <a href="#later-versions-of-accessibility-guidelines" aria-label="Permalink for 0.6 Later Versions of Accessibility Guidelines" title="Permalink for 0.6 Later Versions of Accessibility Guidelines">
   <span>§</span>
  </a>
</span>

gavinhenderson commented 5 years ago

@SteveALee Thanks for the feedback! It felt a bit dodgy when I wrote it so glad you held me accountable to my dodgy code. I am no longer mutating it in place as you suggested. Does my commit solve your concerns?

SteveALee commented 5 years ago

Perfect!

Do you fancy doing the permalink as well? Or I'm happy to just merge this and make that another issue.

gavinhenderson commented 5 years ago

@SteveALee Makes sense just to do it in this PR. Thats the permalink added, whats your thoughts on the styling?

SteveALee commented 5 years ago

Minor comments -

The link seems a bit to low - should sit on the heading letters baseline
Can it be less bolder or lighter colour?

SteveALee commented 5 years ago

PS the link is also appears in the PDF but that's as mkcategories is shared. Really not a problem - just observation. :) Refactor would be expensive

gavinhenderson commented 5 years ago

Changes made :+1:

Yeah it would be either an expensive refactor or a really bad fix if it was done quick. At least links definitely work when exported to PDF so the contents page will work on the PDF which is a bonus

SteveALee commented 5 years ago

@gavinhenderson Looks great! Thanks for updating the built files too.