search

muldjord / skyscraper

Powerful and versatile game scraper written in c++
GNU General Public License v3.0
489 stars 128 forks source link

PSX .bin extension as default #171

Closed HoshiQaVam closed 5 years ago

HoshiQaVam commented 5 years ago

I've noticed that quite a few PSX rom files are shared as .bin files. Of 20 PSX rom files that I have, 17 are .bin and only 3 are .img.

As .bin is not currently a default accepted extension for PSX (though is for other platforms like Megadrive), skyscraper is only finding 3 of my 20 PSX files to scrape.

I appreciate that I can modify the ini file to force skyscraper to look for .bin, or I can go through the frustrating process of converting all of the .bin roms to .img or .iso, but given the high proportion of PSX rom files that appear to be .bin I am surely not the only person with this issue. It would therefore be helpful if .bin became a default.

muldjord commented 5 years ago

Hi, yeah, I am aware of this actually. The problem being that .bin files are very often accompanied by a .cue file for the PSX platform. If I add .bin it will suddenly look for the game twice and also add the game to the gamelist twice. So I've left it out for this reason. You can imagine the mess that would cause for people who only have cue+bin pairs of games (which is many, many cases).

HoshiQaVam commented 5 years ago

How about adding an "excludeExtension" variable either globally or per-system so that we can force the .cue file to be ignored?

muldjord commented 5 years ago

If you are already working at that level you can use the "extensions" config var and just set it to the file types you have. I don't feel like both are necessary.

BenMcLean commented 4 years ago

What would be the correct syntax to include or exclude BIN?

muldjord commented 4 years ago

It's documented here. You would add the following to your ~/.skyscraper/config.ini to completely overwrite the extensions for the psx platform. You can also use addExtensions which appends extensions to those already supported.


[psx]
extensions="*.bin"