esgamelist import module sometimes picks the wrong game to import [DONE]

[akamming]

Describe the bug Tx for this great metadata scraping script! very happy with it. Unfortunately i found a nasty bug which results in some games having the wrong metadata:

When scraping locally not always the right game is picked. E.g. if both "pacman" and "jr pacman" are present in the gamelist.xml, the information for jr pacman is scraped for the pacman game. This can easily be reproduced for other games as well. (e.g. zaxxon gets the metadata of super zaxxon)

I think this is beacuse the compare title is a substring in the title of the other game, where there should only be a hit if the full title matches.

Compare title:  'Pac-Man'
Result title:   'Jr. Pacff-man' ()

To Reproduce (for the pacman / jr pacman example)

1. Make sure the jr pacman info is in the gamelist.xml of mame-libretro:

   
   <game>
   <path>./jrpacman.zip</path>
   <name>Jr. Pac-man</name>
   <cover />
   <image>./media/screenshots/jrpacman.png</image>
   <marquee />
   <video>./media/videos/jrpacman.mp4</video>
   <rating>0.9</rating>
   <desc>One of many sequels to the legendary &quot;Pac-Man&quot;, Jr. Pac-Man features the character of Pac-Man&apos;s son. For the first time in the series&apos; history, side-scrolling mazes were introduced, with each maze being two screens wide. 

This time, the mazes have no exit tunnels through which players can make an escape. The bonus items that appear move around the maze and are now something of a mixed blessing, as not only will they destroy any Power Pills they come across, but they will also turn any normal dots they pass over into large dots that slow the player's movements considerably, but are worth more points than normal dots if eaten by the player. Any mutated dots in the maze will disappear if the player loses a life.

The Pac character is once again pursued by four ghosts (Blinky, Pinky, Inky and Tim) in his quest to eat all of the dots in each maze. And, as before, numerous Power Pills litter the mazes that, when eaten, allow Jr. to eat the pursuing ghosts.

As with previous "Pac-Man" games, intermissions are featured between certain levels. Jr. Pac-Man's intermissions are episodic in nature, like those found in "Ms. Pac-Man". Jr. Pac-Man's story tells of the blossoming love between Jr. Pac-Man and a small ghost named Yum-Yum.

19830101T000000T000000T000000T000000

<developer>Bally Midway</developer>
<publisher>Bally Midway</publisher>
<genre>Action / Labyrinth / Action</genre>
<players>2</players>

and then try to scrape the pacman game locally using this command:
`Skyscraper -p mame-libretro -s esgamelist  --startat /home/pi/RetroPie/roms/mame-libretro/pacman.zip --endat /home/pi/RetroPie/roms/mame-libretro/pacman.zip --videos`

the result is that skyscraper thinks there's a hit: the  pacmanjr info is added to the regular pacman in the cache. so pacman has the wrong metadata.  

**Special circumstances**
no special circumstances: 

**Terminal output**

Terminal output of the command above:

pi@pi-arcadekast:/opt/retropie/supplementary/skyscraper $ ./Skyscraper -p mame-libretro -s esgamelist --startat /home/pi/RetroPie/roms/mame-libretro/zaxxon.zip --endat /home/pi/RetroPie/roms/mame-libretro/zaxxon.zip --videos

Running Skyscraper v3.5.2 by Lars Muldjord

Platform: 'mame-libretro' Scraping module: 'esgamelist' Input folder: '/home/pi/RetroPie/roms/mame-libretro' Game list folder: '/home/pi/RetroPie/roms/mame-libretro' Covers folder: '/home/pi/RetroPie/roms/mame-libretro/media/covers' Screenshots folder: '/home/pi/RetroPie/roms/mame-libretro/media/screenshots' Wheels folder: '/home/pi/RetroPie/roms/mame-libretro/media/wheels' Marquees folder: '/home/pi/RetroPie/roms/mame-libretro/media/marquees' Videos folder: '/home/pi/RetroPie/roms/mame-libretro/media/videos' Cache folder: 'cache/mame-libretro'

DID YOU KNOW: If you use videos and want to save some space, you can use the "--flags symlink" flag to force Skyscraper to link the videos from the cache to the destination instead of copying them. Beware that removing the files from the cache will break the links though.

Reading and parsing quick id xml, please wait... Done! Reading and parsing resource cache, please wait... Done! Successfully parsed 12 resources!

Looking for optional 'priorities.xml' file in cache folder... Not found, skipping...

Trying to parse and load existing game list metadata... Success!

Starting scraping run on 1 files using 4 threads. Sit back, relax and let me do the work! :)

1/1 (T1) Pass 1 ---- Game 'zaxxon' found! :) ----

Scraper: esgamelist From cache: NO Search match: 100 % Compare title: 'Zaxxon' Result title: 'Super Zaxxon' () Platform: 'mame-libretro' () Release Date: '' () Developer: 'Sega' () Publisher: 'Sega' () Players: '2' () Ages: '' () Tags: 'Shooter, Flying Diagonal' () Rating (0-1): '0.9' () Cover: NO () Screenshot: YES () Wheel: NO () Marquee: YES () Video: YES ()

Description: () 'Super Zaxxon is a shoot 'em up arcade game produced by Sega in 1982. It is extremely similar to the original Zaxxon, running on identical hardware and having almost identical gameplay. Like its predecessor the game uses isometric projection, where the player can not only control the ship's left and right movements, but also adjust its height. Primarily Super Zaxxon offers slightly faster gameplay, a different set of graphics, different stage layouts and a few more enemies (including the "Mine Layer" in level 2, and indestructible turrets in level 1). The game is otherwise structured very similarly and has similar goals, but is considered to be the harder game of the two.

In the original Zaxxon, the player is confronted at the end by a large walking machine (called Zaxxon). In Super Zaxxon, it is three robot dragons, with Zaxxon not appearing in the game at all. There are also no space battles in Super Zaxxon, with all action taking place on an asteroid base.'

1/1, (1/0)

Elapsed time : 00:00:00 Est. time left : 00:00:00

---- Resource gathering run completed! YAY! ---- Writing quick id xml, please wait... Done! Writing 12 (0 new) resources to cache, please wait... Done!

---- And here are some neat stats :) ---- Total completion time: 00:00:00

Average search match: 100% Average entry completeness: 78%

Total number of games: 1 Successfully processed games: 1 Skipped games: 0 (Filenames saved to '/home/USER/.skyscraper/skipped-mame-libretro-esgamelist.txt')

(i would expect no hit: The pacman.zip info was not present in the gamelist.xml. Now if i generate the gamelist.xml pacman.zip has the meta info of jr pacman)

**Technical information**
Regular RetroPie image (all components updated to latest version using retropie update script) on a raspberry pi 4

**Additional context**
No addtional context.

[muldjord]

Thank you for the thorough description. This has now been fixed on master. :)

[akamming]

ok...happy to test... is there some instruction how i can build from source on a rpi4 using retropie, so i can test?

[muldjord]

Sure, do something along the lines of:

cd
git clone https://github.com/muldjord/skyscraper.git
cd skyscraper
qmake
make
sudo make install

should do it.

[akamming]

If i build from source using retropie script it compiles version 3.5.5. But using these instructions i get version 3.5.6 and just confirmed the issue is fixed!

now awaiting till it gets into the official retropie build...

Tx, Keep up the good work!