search

mulesoft-catalyst / metrics-toolkit

The metrics toolkit (formerly metrics accelerator/framework) is a Mule application intended to collect, aggregate and load platform metrics into different visualization systems; providing out of the box integrations and visualization options, including useful dashboards and charts.
The Unlicense
84 stars 104 forks source link

APIs with security policy #151

Open saurabhgoyalgithub opened 3 years ago

saurabhgoyalgithub commented 3 years ago

Only APIs secured with client id enforcement are coming into list of APIs with security policy. APIs secured with Ping Federate or HTTP Basic Auth are not considered in the list of APIs with security policy.

richardmckinley commented 3 years ago

Hi @saurabhgoyalgithub

Thanks for raising this issue, it has highlighted an issue with the way these metrics are calculated. I have made changes to /src/main/resources/dw/aggregation/build-platform-metrics-aggregation.dwl to correct this.

I have made the changes available in the branch feature/issue-151 if you would like to try this out.

However, please note that only initial high level testing has been done on this change and it may introduce other issues we may not be aware of until we test in more detail.

In the DW transformation mentioned above, a var securePolicies contains an array of policy asset IDs which are considered security related policies. If you wish to include additional policies, the asset IDs can be added here and should be reflected in the output.

The changes will be included in the next release.

If you have any questions, or notice any other issues please let us know.

Thanks, Richard

saurabhgoyalgithub commented 3 years ago

Thanks @richardmckinley, I will give it a try and let you know in case of any issues.

Regards, Saurabh

richardmckinley commented 2 years ago

Hi @saurabhgoyalgithub I'm going to assume that the fix worked as expected? It would be great to get your feedback in any case. Thanks, Richard

saurabhgoyalgithub commented 2 years ago

Hi Richard,

Sorry for the late reply, I am currently on vacation until 2nd week of January. I will be able to validate the fix once I am back. Thanks for checking.

Regards, Saurabh

On Mon, Dec 13, 2021, 5:56 PM richardmckinley @.***> wrote:

Hi @saurabhgoyalgithub https://github.com/saurabhgoyalgithub I'm going to assume that the fix worked as expected? It would be great to get your feedback in any case. Thanks, Richard

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mulesoft-catalyst/metrics-toolkit/issues/151#issuecomment-992428179, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJFIM4IXHU7SJWPLI54HHJ3UQXQ6PANCNFSM5HEZUK7A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.