mulesoft / docs-connectors

Documentation for connectors
BSD 3-Clause "New" or "Revised" License
25 stars 126 forks source link

Draft 3 is outdated #2680

Closed ca-stefan-cordes closed 1 week ago

ca-stefan-cordes commented 3 weeks ago

Draft 4 was published "Published: 31-January-2013" (wow 10 Years ago). And so support for draft 3 should be stopped. https://json-schema.org/specification-links#draft-3

Writer's Quality Checklist

Before merging your PR, did you:

sathya0 commented 3 weeks ago

Hi @ca-stefan-cordes! Thanks for your contribution. Even though Draft 3 was a long time ago, the operation does still support it right? So I think leaving it in the documentation is accurate. What do you think?

ca-stefan-cordes commented 3 weeks ago

Either add Draft 1 and 2 as well or remove Draft 3 to be able to remove the very old library from mule-json-module

see https://help.salesforce.com/s/case-view?caseId=500Hx00000Zjz9dIAB Case #468142496 mule-json-module depends on two artifacts json-schema-validator which may exceed 200 MB deploy limit

sathya0 commented 3 weeks ago

Hi @ca-stefan-cordes, thanks for the insight. This seems to be a product issue, not a doc issue. If the product team can remove the library from mule-json-module, then we can update the docs accordingly.

sathya0 commented 2 weeks ago

Hi @ca-stefan-cordes, let me know if I can close this PR. Thanks.

ca-stefan-cordes commented 2 weeks ago

Product team is not removing draft-3 support because it is documented.

sathya0 commented 2 weeks ago

Hi @ca-stefan-cordes, our docs have to match what the product supports. I confirmed with the developer that the connector still maintains support for Draft 3 in the current minor version and that support for Draft 3 will not be removed for the time being.

ca-stefan-cordes commented 1 week ago

Hmm. Last time support said: "Connector does not support feature xyz because it is not documented". Seems to be "leading" sometimes is "Connector" and sometimes is "Documentation".

For your reference: https://help.salesforce.com/s/case-view?caseId=500Hx00000Vh9z3IAB and https://github.com/mulesoft/docs-mule-runtime/commit/a582c0e9ede983abb6770a44e69dcbb48d6529ce set-variable name does support dataweave but documentation says: "does not".

Who is leading? Documentation or Implementation?

sathya0 commented 1 week ago

Hi @ca-stefan-cordes, we have no problem updating the docs if the product updates first. The product has to lead. I can't see the support case. Can you send me a screenshot?

ca-stefan-cordes commented 1 week ago

Can you send me a screenshot?

Guess that is not allowed.

ca-stefan-cordes commented 1 week ago

if the product updates first.

Ok. Waiting for product to remove draft-03 functionality.