Update to Manifest v3 - Githubissues

muleyo / VideoAdBlockForTwitch

Blocks Ads on Twitch.tv.

GNU General Public License v3.0

1.63k stars 114 forks source link

Update to Manifest v3 #13

Closed pwltr closed 2 years ago

pwltr commented 2 years ago

revert "remove firefox code"
move inline script to separate file and call from service worker via message call
format files

I think it should be something like this for v3 but I'm having trouble testing since I am not getting ads at all.

muleyo commented 2 years ago

Hi, thanks for the push!

Unfortunately, ads are still present. :/

muleyo commented 2 years ago

Seems like "remove_video_ads.js" is missing. Forgot to upload? :P

pwltr commented 2 years ago

@cleanlock yeah I messed up bad there... had to do git reflog to get it all back

muleyo commented 2 years ago

I merged it. Ads are still present tho. super weird

pwltr commented 2 years ago

Do you have a way to reliably get ads? I seriously do not get any... have disabled uBlock Origin, VPN, different browsers, not getting any

muleyo commented 2 years ago

Yeah I do. Enable the extension for incognito and visit Twitch channels in incognito mode.

pwltr commented 2 years ago

Ah I got one now. Ok, will look into this more tomorrow.

muleyo commented 2 years ago

I fixed it!!! :)

Will push it in a few minutes!