Hybrid embed, proxy, fallback implementation

muleyo / VideoAdBlockForTwitch

Blocks Ads on Twitch.tv.

GNU General Public License v3.0

1.62k stars 114 forks source link

Hybrid embed, proxy, fallback implementation #63

Closed pixeltris closed 2 years ago

pixeltris commented 2 years ago

This is a rough implementation of using the embed player, followed by a proxy (ttv.lol), and falling back to the Commercial Break in Progress screen if both of these fail.

Some notes about the changes:

If the embed player kicks in it wont contact the proxy server which should help reduce any additional traffic to their service.
Both embed and proxy should run at the same resolution as the current player (no more 480p... except on Firefox for the time being)
One request to the main m3u8 has been removed which never really did anything useful (as far as I can tell)
I have removed the stream quality change code path from the chrome code as I don't think it helps and it's annoying. It's still enabled on Firefox as it does help with freezing issues there

I haven't really tested this. I've only tested prerolls. Please test thoroughly before merging.

muleyo commented 2 years ago

Thank you so much for your effort! I'll test this thoroughly and will merge + update the extension asap. <3

pointydev commented 2 years ago

Hopefully if implemented it'll be configurable to disable the use of proxied content as a minor, but important, privacy option.

pixeltris commented 2 years ago

@pointydev yea that's a good idea. Probably opt-in would be best. Maybe a drop-down menu with the values None, TTV LOL, Purple Adblock and default to None. There should also probably be a max resolution setting because some people lag beyond certain resolutions under the proxy.

muleyo commented 2 years ago

Been watching a stream with ads for ~2h in the background with developer console open. Seems to work fine, no stuttering/lags etc.

Yes, you're right. It should be an option to enable proxies etc., also for the resolution. Will probably do that!

thinkpad4 commented 2 years ago

I like the idea of being able to choose the proxy incase one goes down you can switch to the other.

StevensND commented 2 years ago

Been watching a stream with ads for ~2h in the background with developer console open. Seems to work fine, no stuttering/lags etc.

Yes, you're right. It should be an option to enable proxies etc., also for the resolution. Will probably do that!

Working for me without problems too.

vekexasia commented 2 years ago

Hello guys, came here to ask how to install this. I went to my filters tab and entered the following line:

||https://raw.githubusercontent.com/pixeltris/TwitchAdSolutions/master/vaft/vaft-ublock-origin.js

but it does not seem to do anything. And i dont see any console.log message in my chrome. is there anything else i need to do?

lfmnovaes commented 2 years ago

Hello guys, came here to ask how to install this. I went to my filters tab and entered the following line:

||https://raw.githubusercontent.com/pixeltris/TwitchAdSolutions/master/vaft/vaft-ublock-origin.js

but it does not seem to do anything. And i dont see any console.log message in my chrome. is there anything else i need to do?

That's not how to add the script in your uBlock. Follow the instructions in the "Applying a script" section here: https://github.com/pixeltris/TwitchAdSolutions

vekexasia commented 2 years ago

RTFM was a proper answer here :D thanks @lfmnovaes