muleyo / VideoAdBlockForTwitch

Blocks Ads on Twitch.tv.
GNU General Public License v3.0
1.62k stars 114 forks source link

Missing bracket will cause check to always fail. #71

Closed MegaScience closed 1 year ago

MegaScience commented 1 year ago

https://github.com/cleanlock/VideoAdBlockForTwitch/blob/72676a353d0e51e0beb561e10b8f6ae9b5d37d35/firefox/content.js#L210

Because the closing bracket is missing on the referenced line, the query would always fail, resulting in the entire block below never being run.

muleyo commented 1 year ago

There's no bracket necessary? Did you read the code properly?

MegaScience commented 1 year ago

Fascinating, it does still work. It's assuming the closing bracket, though, which isn't behavior to rely on. But I'll close this, then.