muleyo / VideoAdBlockForTwitch

Blocks Ads on Twitch.tv.
GNU General Public License v3.0
1.62k stars 114 forks source link

Is not working rn [2022-11-15] #79

Open carroyo1 opened 1 year ago

carroyo1 commented 1 year ago

Hi, since this morning is not deleting the ads, just showing a screen meanwhile. commercial break

VPVP123 commented 1 year ago

Same for me Sadge

rdutta commented 1 year ago

Try enabling the proxy option. Seems to be working for me. firefox_QBYOC6dHFo

Artis84 commented 1 year ago

still don t work

VPVP123 commented 1 year ago

Try enabling the proxy option. Seems to be working for me. firefox_QBYOC6dHFo

Tried that and it kind of worked, now that "Commercial break" screen just blips up for like 5 seconds and disappears

sycot commented 1 year ago

turning proxy on had no effect for me, still not working

Geczy commented 1 year ago

Same problem, proxy no effect :9

Dio141 commented 1 year ago

not working here either.

palmerbomber1 commented 1 year ago

I mean, Id argue that it is still blocking the ads, its just showing the ad break screen. I do agree that it could use an update, but it might be better to wait a little bit until Twitch stops messing with the ad system

ddday commented 1 year ago

confirmed not working. ads in progress screen and freezing/stuttering

romestylez commented 1 year ago

Enabling the Proxy does work for me. Only problem is that when its blocking ADs sometimes the stream starts to lagg. But its better then having ADs

NBruderman commented 1 year ago

Not working here too. also, for some reason, the chrome web store of the extension is down (getting 404 error)

kazapx commented 1 year ago

Looks like twitch did something for ad blocks.

Pragmageddon8 commented 1 year ago

on my end it keeps freezing the image while the ad is running and the resolution menu keeps opening itself

CrazyWolf13 commented 1 year ago

confirmed it's not working and with proxy the chat goes and stays blank

Gamertech commented 1 year ago

cleanlock knows. Existing issue: https://github.com/cleanlock/VideoAdBlockForTwitch/issues/75

The Chrome store 404 is also known as the exact time Twitch renewed their anti-adblocker campaign, an unnamed person/company filed fraudulent DMCA takedowns against multiple Twitch adblocker extensions: https://github.com/cleanlock/VideoAdBlockForTwitch/issues/74

cleanlock's filed a counter-claim, so it's currently waiting for Google to not be useless and restore it, but as Google are in the process of globally disabling ad and privacy blockers from all Chromium-based browsers, good luck. Swap to Firefox.

CrazyWolf13 commented 1 year ago

cleanlock knows. Existing issue: #75

The Chrome store 404 is also known as the exact time Twitch renewed their anti-adblocker campaign, an unnamed person/company filed fraudulent DMCA takedowns against multiple Twitch adblocker extensions: #74

cleanlock's filed a counter-claim, so it's currently waiting for Google to not be useless and restore it, but as Google are in the process of globally disabling ad and privacy blockers from all Chromium-based browsers, good luck. Swap to Firefox.

Damm I use opera GX is there any way to get it to work ? Maybe Opera Add-On Store?

CrazyWolf13 commented 1 year ago

cleanlock knows. Existing issue: #75

The Chrome store 404 is also known as the exact time Twitch renewed their anti-adblocker campaign, an unnamed person/company filed fraudulent DMCA takedowns against multiple Twitch adblocker extensions: #74

cleanlock's filed a counter-claim, so it's currently waiting for Google to not be useless and restore it, but as Google are in the process of globally disabling ad and privacy blockers from all Chromium-based browsers, good luck. Swap to Firefox.

Why doesn't he make a userscript that would solve so many issues like Google DCMA and many more

Gamertech commented 1 year ago

@CrazyWolf13 I have no idea who cleanlock is or how they think, but from my point of view: what's the point in porting a defeated adblocker to a userscript before the adblocking is fixed? Fixing the extension and getting rid of the ads is the priority, then can maybe look into the large amount of (unpaid) work needed to port it to another format.

Opera will also be impacted by Google's war on ad and privacy blockers and already has a heap of known tracking and privacy issues built in. Currently the only known browser that wont be affected is Firefox. They also are not affected by fake DMCA claims, meaning the extension is still available in the FF store.

CrazyWolf13 commented 1 year ago

@Gamertech For sure i completely agree but if you make a fix and 2/3 can't use it cause of Google DCMA :/ For Adblock i have a RaspberryPi with AdGuard works like a charm :)

mallochine commented 1 year ago

when is cleanlock going to fix this?

TiagoAndreAlmeida commented 1 year ago

i using vivaldi browser and change proxy to TTV LOL, help to block 90% of ad's. some time add show but 5 to 6 second her gone and stream back.

muleyo commented 1 year ago

Hey guys,

I'm aware of the issue. I simply don't have much time at the moment to update. If someone wants to contribute code, feel free to do so. I'll check and merge it then.

Also, proxy is still working for me. Not as good as before the twitch update, but at least there are no ads.

arabyalhomsi commented 1 year ago

Hey, it's still not working! makes me sad. Could you lead me into how to contribute to this?

muleyo commented 1 year ago

Hey, it's still not working! makes me sad. Could you lead me into how to contribute to this?

You can simply create a fork, make your changes and then create a pull request.

Manastis commented 1 year ago

Hello! I just wanted to install the adblocker for my wife and found this here .. and wanted to let you know that i dont have any issues with the 5.6.0 version? I dont get any purple screens or something like that .. I just went to the same stream where my wife gets the purple stream and i dont get it. So maaybe this version is still cool?

carroyo1 commented 1 year ago

Few updates: I have update to the last version like @Manastis have said and It works.

Manastis commented 1 year ago

happy to help :D.. but im curious where you found this version, for install also to my wifes pc.. cant find it D:.. btw im with chrome. The Firefox looks like have still that version

palmerbomber1 commented 1 year ago

happy to help :D.. but im curious where you found this version, for install also to my wifes pc.. cant find it D:.. btw im with chrome. The Firefox looks like have still that version

IIRC it's not currently available on Chrome due to a false DMCA report

palmerbomber1 commented 1 year ago

https://github.com/cleanlock/VideoAdBlockForTwitch/issues/74#issue-1437647403

Manastis commented 1 year ago

happy to help :D.. but im curious where you found this version, for install also to my wifes pc.. cant find it D:.. btw im with chrome. The Firefox looks like have still that version

IIRC it's not currently available on Chrome due to a false DMCA report

ofc .. but u can still install it manually .. so i thought he found the version for chrome here somewhere

gaekwad commented 1 year ago

I have 5.6.0 on Firefox and the problem is happening for me, so I'm not sure how it's not happening for other people.

aldelaro5 commented 1 year ago

Same deal here, I made sure to update, I am on 5.6.0 and it's been much less consistent than before (it often can fail to block or do weird things like lowering the stream volume and pop the quality options without me clicking on it).

Steelviper44 commented 1 year ago

can confirm it is not working

carroyo1 commented 1 year ago

happy to help :D.. but im curious where you found this version, for install also to my wifes pc.. cant find it D:.. btw im with chrome. The Firefox looks like have still that version

IIRC it's not currently available on Chrome due to a false DMCA report

ofc .. but u can still install it manually .. so i thought he found the version for chrome here somewhere

I've installed it manually again, at first it works, but in an hour or two, again failed. I have asked my mates and even though they are subs they are watching ads too...

FinalNene commented 1 year ago

Can confirm that it's also broken for me since +/- a week ago.

ara303 commented 1 year ago

@cleanlock Consider closing this issue (and #75) because it's just gonna get "yep, it's broken" comments indefinitely.

CrazyWolf13 commented 1 year ago

@cleanlock Consider closing this issue (and #75) because it's just gonna get "yep, it's broken" comments indefinitely.

Tissue is still now gone someone will immediately open a new one. Maybe there is someone who can code and help cleanlock.

There were also so replys that it's working.

I think not this would be a good idea.

TsukiZero commented 1 year ago

IIRC, Twitch Ad Solution New Video-Swap supposedly works for midrolls, but not Pre-Rolls (display a new adbreak screen), meanwhile VAFT works for Pre-Rolls but not SOME midrolls (which displays the Commercial Break screen). Now if someone merged those in such a way that one runs for prerolls and the other for midrolls....

Update: OK, neither works for prerolls, NVS however shortens all prerolls to a single 15 seconds preroll standby. Now the question is if someone can spoof that to think 15 seconds have already passed.

Arandomnameok commented 1 year ago

it's not even blocking prerolls now and midrolls sometimes it works and other times it just freezes.. sad times..

Squallsoldier commented 1 year ago

Can confirm that works for me with the following settings: Firefox/ Version 5.6.0/Proxy TTV LOL/1080P, Located in Mexico (if location matters)..

CrazyWolf13 commented 1 year ago

I can confirm it does work sometimes but kind of inconsistent sometimes it does sometimes not and there is the commercial break screen for some seconds, the player pausing itself while blocking ads or the chat completely vanishing. TTV LoL Proxy 1080p

TsukiZero commented 1 year ago

While using pixeltris's Twitch Ad Solutions (video-swap-new), I realized two things:

  1. The Preroll time is consistent 15 seconds, and always shows the placeholder screen.
  2. After the Preroll plays once, resetting the player, pausing & playing, won't cause the Preroll to be played again. HOWEVER if the page is refreshed then it will start playing again.
mallochine commented 1 year ago

@cleanlock seems like this extension engineering approach (of switching to lower quality stream (480p) and then to higher quality) is a dead-end now. @Cleanlock is my assessment correct?

pixeltris commented 1 year ago

@mallochine definitely dead for prerolls. For midrolls it might still work somewhat but I'm not certain the currently set fallback player type of thunderdome is working. picture-by-picture should work on streams which have it enabled (it should be enabled by default according to this https://help.twitch.tv/s/article/picture-by-picture-ads). Unfortunately I haven't had the time to watch streams long enough to test midrolls to see what improvements could be made.

@TsukiZero there should be a server side cooldown period on prerolls (5-10 mins). If you're not observing the cooldown you might need to tweak the script by disabling OPT_ROLLING_DEVICE_ID.

romestylez commented 1 year ago

Im using the latest version on the latest chrome and its working. Sometimes i see the "Advertising in progress" screen for a few seconds when switching to a stream but most of the time it gets blocked.

Only "problem" is that when the ads getting blocked the video is sometimes very laggy and also the chat is laggy. But when ads are gone its all fine.

CrazyWolf13 commented 1 year ago

Sadly if i have the adblocker enabled my chat does not load at all / or dissapears when it starts blocking ads

crisp5 commented 1 year ago

If anyone is blocking 3rd party domains with uBlock along with the TTV LOL proxy, make sure to graylist the ttv.lol domain.

Manastis commented 1 year ago

ok i extracted the 5.6 version for chrome from my browser.. for me like i said its still working, so lets see if this helps

5.6.0_0.zip

edit installed at wifes pc .. blocking adds working fine.. lets see with u guys :3

romestylez commented 1 year ago

You can just download that version from the GitHub here so why you extract and upload it ?

Manastis commented 1 year ago

in github i just can see the 5.4? -.o so i thought it would be not here.. i searched for D: