search

mulfok / obsidian-absolve

A theme overlay snippet for Obsidian.md
34 stars 1 forks source link

Minor issue with prism highlights #6

Open brimwats opened 2 years ago

brimwats commented 2 years ago

I am unsure if this is absolve, minimal, or obsidian, but there seems to be a minor fight with checkboxes and the prisim hilighter:

image

mulfok commented 2 years ago

I see I see--would you mind sending a screenshot with other levels of indentation? I'm trying to fix the issue on my end, but just want to be sure of what exactly I should change.

In terms of what is actually causing this, it's Minimal

brimwats commented 2 years ago

For sure!

image

however it happens on other themes image

brimwats commented 2 years ago

(second theme is Obsidian You)

mulfok commented 2 years ago

So, I've had a couple of ideas and tweaks concerning this, but the one that is "easiest" to implement, and will not screw with anything concerning Live Preview or CodeMirror, is simply just:

  1. Removing the indicator for a list with no indent
  2. Shrinking all the indicators

The image below is doing this with Minimal--curiously, Minimal (and perhaps other themes) seems to get the beginning of their checkboxes cut off when using prism lists.

image

...Live Preview moment. I think I'll dedicate an update to fixing issues with the mode specifically; I don't really use Live Preview, and have stuck with Source Mode mainly due to its stability.

In the meantime, if you find that the current changes are okay, I can push a bugfix release as a temporary solution--at least until I can get to the bottom of the checkbox trouble in LP.

brimwats commented 2 years ago

I think either works fine! I'll just note that it's not checklists that I get that problem—its any list (in this case, a dash)

mulfok commented 2 years ago

Okay, v2.5.1-beta has implemented the various tweaks and stuff. I'll look into how to fix the strange cut off with lists !