mulimoen / rust-blosc-src

4 stars 2 forks source link

Investigate c-blosc-2 #10

Open mulimoen opened 1 year ago

mulimoen commented 1 year ago

@maiteko has started working on this in [0], should investigate how to help with this effort and maybe use the crate directly with COMPAT_MODE set

[0] https://github.com/maiteko/blosc2-src-rs

maiteko commented 1 year ago

Heh. So you've seen me.

blosc2-src-rs is based off this repo, so I'd be all for working with you to make sure it stays maintained. (or, at the very least, the crate is maintained). There's a couple of kinks between building for c-blosc and c-blosc2, (primarily zlib).

mulimoen commented 1 year ago

You showed up in #7 :smile: I have refactored dependencies on external libraries slightly in #11, does that make it easier to include zlib?

maiteko commented 1 year ago

Hmm, unless I'm misunderstanding your changes, using the sys crates would be a step backwards for my use case (hence why I based off of yours). My goal was the build should just work out of the box without setup beyond rust.

here are the differences that I remember:

I don’t personally need zlib, and the other two worked fine using the bundled version. I'm only bringing it up as a potential hurdle if someone wants to use cblosc2 and needs zlib.

Maybe use sys for zlib support. Or maybe give both options for zstd and lz4 (ie have both lz4-bundled and lz4-sys features).

Edited to clarify my prior statements. was rushed earlier.