mulle-nat / mulle-xcode-to-cmake

🎭 Convert Xcode projects to cmake CMakeLists.txt
118 stars 18 forks source link

Fixed broken execute_process() call under GNUstep shell on Windows #11

Closed ElMostafaIdrassi closed 5 years ago

ElMostafaIdrassi commented 5 years ago

For gnustep-config bash script to be invoked properly by execute_process() under GNUstep shell on Windows, the ${GNUstepConfig} call must preceded by sh. Otherwise, execute_process() fails, leading to objc_def_flags and objc_def_link_flags being empty, with RESULT_VARIABLE containing : %1 is not a valid win32 application.

mulle-nat commented 5 years ago

The existing GNUstep code was written by someone else, so I can only guess if yours is correct or not (same for the old GNUstep code though). I don't want all that text in the README.md though. I'd put that into a separate BUILD-GNUSTEP-WINDOWS.md if that's OK with you,

ElMostafaIdrassi commented 5 years ago

Well you can give it a try if you have some time, without adding sh in the execute_process(), the compiler and linker flags are empty on Windows, you can print them using message( STATUS...), and without the manual trick, the build fails.

Maybe you should add a note that this was the behaviour using GNUstep shell from MSYS version 0.30 downloaded from here and it comes with GCC 4.6.1.

For the Windows build steps, feel free to manage that as you wish ;)

Cheers

mulle-nat commented 5 years ago

I will probably put up a new version of this and some other changes this week.