search

mullema / k3-panel-view-extended

Quick fix for some missing features in the panel
MIT License
27 stars 2 forks source link

This fantastic plugin seems to not work with the version 3.5.7.1 of Kirby #15

Closed ktryndchrs closed 2 years ago

mullema commented 3 years ago

It works perfectly fine with Kirby 3.5.7.1. With a more specific description of the problem you are experiencing, I may be able to guide you in the right direction.

ktryndchrs commented 3 years ago

Sorry for the late answer @mullema .

The current version of Kirby we are using is 3.5.7.1

Ands I figured the reason which was a in-house custom plugin specific to our client needs that extends the k-page-view

This was implemented by another member of my team and I will look with him about more details about this piece of code on monday.

export default {
  extends: 'k-page-view',
  updated ():void {
    if (this.blueprint !== 'pages/default' && this.blueprint !== 'pages/home') {
      this.$nextTick(() => {
        this.permissions.preview = false
      })
    }
  }
}
mullema commented 3 years ago

Hi @ktryndchrs Unfortunately these two plugins are not compatible with each other.

ktryndchrs commented 3 years ago

Exactly, I will figure something with my team as your plugin is quite a necessity for a better UX on the panel

mullema commented 3 years ago

In case you update to Kirby 3.6 it would be easy to just add your updated() method to my plugins index.js here: https://github.com/mullema/k3-panel-view-extended/blob/78e68dd9231ebb85edf6cbf7acc6b154a599e482/index.js#L7

ktryndchrs commented 3 years ago

Kirby 3.6 seems like a real deal. I can't wait to play with it …

mullema commented 3 years ago

You can already play with it. https://github.com/getkirby/kirby/releases/tag/3.6.0-rc.3