muller317 / pe

0 stars 0 forks source link

Error message for add student is too general #5

Open muller317 opened 1 week ago

muller317 commented 1 week ago

image.png After keying the my diy command, I cannot precisely locate which has the formatting error upfront other than validating the supposed format 1 by 1 and making sure I comply in every category which is time-consuming and sometimes confusing.

nus-pe-bot commented 1 week ago

Team's Response

Thank you for your feedback! The command example provided is failing because the command format is inaccurate. It is missing the s\ before the subject Science, and in the error message also mention that the command is failing due to incorrect format error and provided the correct format error at the Format: add n\NAME …

We understand that locating this format error may be a bit time-consuming, but this to standardize the error message displayed when user key in the command with invalid format(missing field or prefixes) and currently add is the only feature that require a long command format that causes a longer time to check.

We appreciate your feedback and we would consider in the upcoming future to implement for specific error command such as indicating which prefix is missing for the user command.

We also believe that this is not in scope in terms of the current development phase of the product since our app does provide an error message to guard against such inputs, and our error message clearly highlights that the input is incorrect because of a format error in the command instead of just a general error message.

Thus we would agree that this is a valid enhancement on top of the current feature we have already implemented and will include this in our future implementation plans. Thank you for your suggestion but unfortunately our team would like to put this issue under not in scope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]