search

muller317 / pe

0 stars 0 forks source link

Error message for addsubject is too general #6

Open muller317 opened 1 week ago

muller317 commented 1 week ago

addsubject S00003 s\Chinese s\Malay s\Tamil s\Math s\Further Math s\Science s\History s\Geography s\Literature s\Economics s\Accounting s\Business s\Physics s\Chemistr s\Biology this is the command I used

image.png This is the error message I get, if the user is trying to add multiple subjects and maybe some of them are invalid, the user will need to search the entire list of available subjects for each subject the user inputted to find which one are the invalid subjects, in this scenario of overzealous inputs rejected, it will be time consuming for the user to rectify and find out what went wrong.

soc-pe-bot commented 1 week ago

Team's Response

Thank you for your feedback! After reviewing your comment, we would like to suggest that this bug is not in scope for the current development phase.

Screenshot 2024-11-18 at 10.04.30 PM.png

As mentioned in our UG(provided above) and the error message, currently we only support the provided subject for the user to assign to the student. This is to ensure that the tag used for indicating subject is standardized and user are not allowed to input miscellaneous input and indicate it is a subject. For example the command provided is failing because the spelling for Chemistry is missing a y. If we allow Chemistr to be added instead of doing the validation checking, when carrying other operation such as filtering by subject Chemistry, the student that is assigned Chemistr will not be filtered out, which could cause some operation issue.

First of all, the current subject provided is the subject that is usually offered by the primary or secondary tuition center. These subjects are set as enum for validation checking. As our target user is small to medium size tuition centers for primary or secondary school, which is unlikely to provide a large amount of subjects in the tuition center. The user, which is the tuition center administrator, should know which subject is provided by their tuition and know which subject is a valid input and which is not.

Besides we also understand that it is a bit tough to check the validation of subject when a lot of subject is added to a student, but it is very unlikely, or rarely that a student will take such a large number of classes in a tuition center at the same time that makes checking challenging, as it is an unreasonable workload to be handle by the student, and the ability for a small/medium size tuition center to provide a huge range of subject is not so realistic.

Next, to address the problem of rejecting overzealous inputs, we understand that limiting input could be troublesome for some tuition centers if they want to customize their own subject. Hence we did have a planned feature for the upcoming version to allow users to customize the subject provided by the tuition center. As provided in the screenshot below taken from our UG.

Screenshot 2024-11-18 at 10.06.05 PM.png

Lastly, the product is not behaving not as expected or specified, thus this is not a functionality bug. The validation checking and rejecting the input that does not match the supported subject is a feature, not a bug.

Our goal is to ensure that the features we provide align with the needs of small to medium-sized tuition centers, while also maintaining data integrity. Once again, we appreciate your feedback.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]