mullvad / mullvad-browser

Privacy-focused browser for Linux, macOS and Windows. Made in collaboration between @torproject and @mullvad
https://mullvad.net/browser
1.22k stars 24 forks source link

Bitwarden Unlock Vault Window #202

Open akovia opened 8 months ago

akovia commented 8 months ago

Mullvad: 13.0.7 (based on Mozilla Firefox 115.6.0esr)

I'm not sure if this is a Bitwarden issue or a browser issue, but the window to unlock your vault the first time opens mostly off screen and is way over-sized. Once you've completed the login to the vault, the extension seems to be working normally.

In the second screenshot I placed the window onto the browser window and it appears to be the same size.

Another thing that may not be of note is that the Bitwarden window will remain even after closing Mullvad.

Edit: I just discovered that it works normally if you select the Bitwarden icon to enter your vault credentials. The issue arises when using the vault shortcut to enter your credentials. Ctrl+Shift+L.

This is how I normally activate the extension. After opening my browser I would navigate to a site and when prompted for credentials I would use the shortcut. It would then prompt me to unlock the vault and would enter the credentials immediately after unlocking. So something is different about calling the extension via the shortcut only.

Mullvad-Bitwarden1

Mullvad-Bitwarden2

Thorin-Oakenpants commented 8 months ago

it's opening in a new window and sizing to 1400 x 900 max width x height - I just replicated it

Thorin-Oakenpants commented 8 months ago

https://github.com/bitwarden/clients/releases/tag/browser-v2023.9.0

  • Launch unlock or login in new window when auto-filling
Thorin-Oakenpants commented 8 months ago

here's all the gory details: https://github.com/bitwarden/clients/pull/5384

akovia commented 8 months ago

here's all the gory details: bitwarden/clients#5384

Gory indeed. Thanks for the speedy attention.

Thorin-Oakenpants commented 8 months ago

so this is triggered by RFP's newwin restrictions - I will log a ticket for it to not apply to moz-extension:// scheme but this is not as simple as it sounds

Thorin-Oakenpants commented 8 months ago

https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42350

Thorin-Oakenpants commented 3 months ago

I'm not sure where Bitwarden is at with this issue, but we have decided to not exempt windows opened with moz-extension:// scheme

Whilst I think the risk is low (if you vet your extensions for sure, and as fallback have letterboxing on), it's not worth the risk or maintenance or implementation for us in Tor Browser (and by extension, pun intended, Mullvad Browser)

As ma1 pointed out Bitwarden could use the windows.update() API

cc @ruihildt wontfix

Thorin-Oakenpants commented 3 months ago

also, it seems the current Bitwarden has changed how they do it - it's anchored to the unified extensions button or the toolbar button if pinned there - so BW issue resolved :)

okie dokie