search

mullvad / mullvad-browser

Privacy-focused browser for Linux, macOS and Windows. Made in collaboration between @torproject and @mullvad
https://mullvad.net/browser
1.14k stars 21 forks source link

Initial window de-maximizes when using Only Show on New Tab #270

Open eiqnepm opened 1 week ago

eiqnepm commented 1 week ago

Tools > Settings > General > Window size > Reuse last window size when opening a new window View > Toolbars > Bookmarks Toolbar > Only Show on New Tab

When opening Mullvad Browser and visiting a site for the first time the window will minimize.

Thorin-Oakenpants commented 1 week ago

worksforme on windows. What is your OS?

Thorin-Oakenpants commented 1 week ago

What I do note is that on the first site visit the window size snaps to letterboxing dimensions - which may be due to https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42192

i.e we shouldn't resize the window if remember last size is enabled - edit: maybe/maybe not = we need to think thru the logic

cc @hackademix

hackademix commented 1 week ago

By "minimize" you mean literally disappear in the dock / apps bar or whatever, or rather scale back to a slightly smaller size making up for the disappearing toolbar (which would be expected, even though debatable, per https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42192 ?)

eiqnepm commented 1 week ago

By "minimize" you mean literally disappear in the dock / apps bar or whatever, or rather scale back to a slightly smaller size making up for the disappearing toolbar (which would be expected, even though debatable, per https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42192?)

On Windows the window goes from being fullscreen to a smaller sized floating window. Not F11 fullscreen, just maximized window.

hackademix commented 1 week ago

On Windows the window goes from being fullscreen to a smaller sized floating window. Not F11 fullscreen, just maximized window.

OK, I can reproduce it on the Tor Browser as well. We probably don't want snapping down letterboxing size if the window is maximized. Open an issue on our tor tracker, thanks.

Thorin-Oakenpants commented 1 week ago

i opened https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42678 and pinged you @hackademix

Thorin-Oakenpants commented 1 week ago

title is misleading - it's "initial window de-maximizes when..."